Ivan Dlugos
Ivan Dlugos
> I was wondering whether I could start & stop a session, in the beginning, to force the rundown to happen and then use these events to feed TraceLog. Afterwards,...
@brianrob Any chance you could have a first look at `TraceLog.cs` changes if they seem reasonable? If so, I'd update tests to cover the changes & mark this PR as...
> @vaind, the concept here looks good. One thing I think we will need to resolve before this is ready for review is the rundown design. Your instinct to trigger...
> @vaind, once you're ready, go ahead and mark this as ready for review and I'll take a more thorough pass on it. I've done so. It does need tests...
P.S. I've tested it as a consumer in [Sentry .NET SDK](https://github.com/getsentry/sentry-dotnet/pull/2385). What I meant by needing tests is that it needs tests in this repo.
> I've made some changes as requested and replied to some questions. > > Keeping the testing open until the questions are resolved. @brianrob Have you been able to finish...
@brianrob I'd say this is "done" from my POV. Please let me know if there are any more changes you'd like me to make. The CI fails with a lot...
> FYI, I am in the middle of reviewing this, but need to stop right now. Things are looking good though - I need to look at the test changes...
> In my testing over in #1894 I discovered that running each of the test assemblies separately works. It seems that the combination of all of the test runs is...
Hi @brianrob, I've updated this PR with the latest changes from the main branch and all the CI jobs pass. Is there anything I should do to so that these...