Ville Aikas
Ville Aikas
Also chiming in from the policy-controller side, I did add this for policy-controller that should pull all the things that could be SANs (might have made a mistake of course):...
Another one we should do is validate the glob string. My understanding is that we only support 'one' trailing '*' character. Since parsing functions have traditionally been a source of...
Also, when we add validation for inline data being a valid public key, we should also reuse that validation to address the public key we get from the secret. I...
FYI, just to make sure you're aware, but there's this PR moving much of the code sigstore/sigstore: https://github.com/sigstore/sigstore/pull/435
Changing one hard coded value for something else with no way to override does not seem ideal. Since it seems like some resources will maybe require specifying different values, I...
Yeah, I think a global flag is fine as long as it's configurable I'm fine with it. Would it be bad to put it in knative.dev/pkg/apis/contexts.go which has bunch of...
/lgtm /approve
this may be relevant for the discussion here too: https://github.com/theupdateframework/go-tuf/pull/397
We should add these in to the list that we care about, utilizing this: https://github.com/knative/pkg/pull/2547 Of course, we also need to validate them in the actual webhook.
I want to add the e2e tests for it.