cosign icon indicating copy to clipboard operation
cosign copied to clipboard

[WIP]: Air gap support

Open vaikas opened this issue 2 years ago • 3 comments

Summary

Use newer version of theupdateframework/go-tuf, sigstore/sigstore https://github.com/theupdateframework/go-tuf/pull/397 https://github.com/sigstore/sigstore/pull/715

I'll add an e2e test once I can get the e2e test here (that I'll use this version of cosign then from) to test this new behaviour. But you can see it works here: https://github.com/sigstore/scaffolding/pull/382/files#diff-6fc761a0f69ff1560f6fb38a4bc8c509cb4d9c68df250223f765ca6564521119R208

And a passing run (one of them) here: https://github.com/sigstore/scaffolding/actions/runs/3139401394/jobs/5099778594

Release Note

  • Add support for air gap scenarios by being able to initialize TUF root where remote is local filesystem.

Documentation

vaikas avatar Oct 01 '22 22:10 vaikas

Codecov Report

Merging #2299 (0528e19) into main (35595e8) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2299   +/-   ##
=======================================
  Coverage   30.48%   30.48%           
=======================================
  Files         136      136           
  Lines        8384     8384           
=======================================
  Hits         2556     2556           
  Misses       5494     5494           
  Partials      334      334           
Impacted Files Coverage Δ
cmd/cosign/cli/options/initialize.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Oct 01 '22 22:10 codecov-commenter

Is this ready for review?

dlorenc avatar Oct 15 '22 20:10 dlorenc

I want to add the e2e tests for it.

vaikas avatar Oct 17 '22 16:10 vaikas

ho hum, I see we need to add the required tests because I added a new matrix segment for this to be considered passing.

vaikas avatar Oct 21 '22 20:10 vaikas

thanks @znewman01 ! Yeah, all the "real" work was in upstreams :) Here's just tests.

vaikas avatar Nov 07 '22 22:11 vaikas