vaerian

Results 14 comments of vaerian

> One thing I am curious about is how would someone make an enchantment that can, for example, be applied to a certain item only via enchanted book but not...

Apparently the way vanilla does it, is that some enchantments indicate that they can be added to an item, but those items don't indicate that they're enchantable, so the result...

Actually it might be wiser to just let individual mod authors mix into the item they specifically want to target, because in the grand scheme of things it's about the...

This would actually probably be a good idea because it would cut out this extra registry iterator I had to make by instead having static compile time knowledge of the...

Okay I addressed the functionality Pros mentioned in https://github.com/FabricMC/fabric/pull/1102/commits/6aa093b2255a6fd201329c3bb23f70192fcb58bd. There was some discussion on how to handle this anvil situation. I chose to keep the actual code in the PR...

Alrighty, this should be done now! I can't conceive of anything else I'd want to add to it. There's now a callback event for applying an enchantment in the anvil,...

Ahhh I screwed things up oh no, okay I can fix this

Real talk I have no clue what's going on with the build test right now, it would be awesome if someone could take a look at that, because locally everything...

Fixed, could've sworn it was meeting the checkstyle earlier, really thought it was something else causing the error.

Everything has been changed to match the suggestions, the one thing I didn't change was the author tags in the javadocs for the reason I outlined above. I figure it...