felipe stival
felipe stival
I think it's a good idea, it's what I would expect Ecto to do. My only (slightly unrelated) question is if we should perhaps auto-propagate logger metadata as well. If...
Maybe this could be released under another name on opam while keeping the fork status in the repository? This would solve https://github.com/anmonteiro/piaf/issues/90 and other compatibility issues without "stealing their thunder"...
Does the alternative function where you can pass host and port separately works? I think the current logic that splits host/port from an address isn't capable of handling ipv6 addresses....
I feel like the conditional state index isn't a great approach, the race condition persists (although with a smaller window), as the first task may be picked up and changed...
Perhaps unique could be resignified to "unique within period of time" instead of "unique within state"? 🤔 Maybe this would require significative changes.
This is a WIP, I'm opening for reference. I need to double check some corner cases and maybe my implementation can be simplified.
Also it looks like CI is failing for totally unrelated reasons™️
Yeah, will try to send one soon!
How could we watch those?