mint
mint copied to clipboard
elixir-mint
Don't send RST_STREAM when not needed
When the stream state is local_half_closed and an end_stream flag is received, the stream can be terminated normally without RST_STREAM.
Closes #433.
I still didn't work on integration tests, and while current tests kind of cover this feature, I'll add a specific test for it.
Pull Request Test Coverage Report for Build e6a3aac052f01725352df867c357cb80818e034f-PR-434
Details
- 9 of 12 (75.0%) changed or added relevant lines in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-0.1%) to 87.766%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| lib/mint/http2.ex | 9 | 12 | 75.0% |
| <!-- | Total: | 9 | 12 |
| Totals | |
|---|---|
| Change from base Build cb43462e784e1d34215bc9da44bd4a25d0a9a5c1: | -0.1% |
| Covered Lines: | 1277 |
| Relevant Lines: | 1455 |
💛 - Coveralls
This is a WIP, I'm opening for reference. I need to double check some corner cases and maybe my implementation can be simplified.
Also it looks like CI is failing for totally unrelated reasons™️
Yes Totally Unrelated™, no worries
I'm not 100% happy with the implementation because I think it's a bit dirty, but it solves the problem and is pretty small, so I'm opening the PR.
@v0idpwn is this ready to review?
