Slava
Slava
@theory Hi! Could you please let me know what you think about my PR. I'd appreciate it.
> Not a full review, but a couple comments: > > AFAIK, there's no reason to modify the `unpackaged` script. > > Instead of building a function body via `||`,...
@theory Hi, I am going to implement the following features. Please let me know if you think they are a good idea too. > 1. Spy on a routine. This...
> Honestly this is a huge feature that I think should probably be its own extension, either distributed separately and depending on pgtap (perhaps a release that includes changes to...
So, what is the best solution?
> > So, what is the best solution? > > I suggest you continue developing in your own project, a separate repo. I'd be happy to review stuff there if...
@theory I moved all my code to my own repo. > So it replaces the function in the same schema? I presume you're depending on a transaction ROLLBACK to rollback...
> Reviewing the changes to tap_funky, I'm starting to wonder whether they're needed in pgTAP, or if you'd be able to use a function or view in your mock extension...
> This issue is not solved simply by making a temp table non temporary. I have done that in order to gain more visibility. The issue is that procedures run...
@diraneyya here how it looks One note. My functions are in schema "tap". That's why I use search_path. Anyway please note when you are in a cycle you have to...