deep_uncertainty_estimation icon indicating copy to clipboard operation
deep_uncertainty_estimation copied to clipboard

passing the varience to the function compute_log_likelihood() in file eval.py

Open MoHassoubah opened this issue 3 years ago • 2 comments

Hello ,

thank you very much for your effort,

I have a question, in file eval.py the function compute_preds(), returns the variance of the model "model_variance", then the variable "outputs_variance" is passed to the function compute_log_likelihood() as "sigma" yet in the function compute_log_likelihood(), the function torch.distributions.normal.Normal() takes "loc" which is the mean of the distribution and "scale" which is the standard deviation yet you are passing the variance not the std to "scale"??

MoHassoubah avatar Sep 14 '21 17:09 MoHassoubah

@mattiasegu

MoHassoubah avatar Sep 15 '21 15:09 MoHassoubah

Hi @MoHassoubah, you are right, it should be the std! I fixed this already in the version of the repo on my github: https://github.com/mattiasegu/uncertainty_estimation_deep_learning

mattiasegu avatar Sep 17 '21 08:09 mattiasegu