Usman

stop the callback for button elements, too

1

Buttons are primarily used as form elements, behaving essentially as inputs. For consistency's sake, we should treat them as such and not fire the callback when the event target is...

Improve documentation on workflow transitions

3

I want my team to be able to take advantage of workflow transitions without having to learn Smart Commits. I saw after setting up the Jira integration that this is...

[github] Don't consider PR body in CI skip logic

12

GitHub pull request edits weren't triggering CI when the PR body/description contained the [ci skip]/[skip ci] pattern. This was an issue, for example, in Dependabot-generated PRs that include commit messages...

Exclude stderr (e.g. deprecation warnings) when parsing command output. Signed-off-by: Usman **What this PR does / why we need it**: It ensures that warnings or other output that goes to...

Meta: maintenance tasks for next release

2

Some stuff to do for v1.2.0: - [ ] **Reevaluate this list!** Move some tasks to other tickets/releases, possibly use "Projects"? - [x] merge `develop` branch into `master` - [x]...

jQuery 3.3 [removed](https://api.jquery.com/category/deprecated/deprecated-3.3/) the `$.isFunction()` & `$.isNumeric()` functions, which can replaced by vanilla JS. We don't need to replicate the extra browser-specific check in `$.isFunction()` (i.e. some built-in functions are...

Maintenance: Identify and remove all dead code

1

I spy lots of dead or otherwise crufty code. We should get rid of that.

scale: 'auto'

4

Allow the `scale`, `minScale` and `maxScale` options to take a value of `'auto'` (this should become the default value for `scale`.) When specified, a value of `'auto'` should choose a...

Cleanup: fix/simplify the construction of navigation markup

3

[This is ugly.](https://github.com/taitems/jQuery.Gantt/blob/7038cec5de44c6c212b2f03611c4cc2f3b045b56/js/jquery.fn.gantt.js#L759-928) (...and doesn't indent well, either!) The infinite chain of function calls seems wildly unnecessary. The element could just as easily be built using a single string of...

Tests should be added for at least the most basic use cases as well as for each confirmed bug and pull request (going forward). (Should probably also standardize on a...