Yusaku Inoue
Yusaku Inoue
Hi, @brillout! May I work on it?
@brillout Let me ask a question. Should prefetchPageContext.when default to false? Also, do I need to support override for individual links?
@brillout OK, I'll implement `HOVER` as default for now🙆♂️ > Or do you see an issue with that? I don't have at the moment. I just asked to be sure,...
@brillout I would appreciate some guidance on how to determine when the prefetch of `pageContext` is complete. While I have managed to fetch the context containing `config`, `exportsAll`, etc., when...
@brillout Thank you for your response; I await your further insights.
@brillout > Have a look at renderPageClientSide.ts, that's where the whole client-side rendering orchestration happens. This file has a globalObject so I think we can save the prefetched pageContext there....
@brillout I think the PR is now ready for review. Could you please take a look? Also, some CI tests has been failing since [the second to last commit](https://github.com/vikejs/vike/pull/1617/commits/077d865e3ac16f29f0d3b177535690c84927094a), and...
@brillout Thank you for your review! Except where I responded to your comments, I have updated based on your feedback. Could you please check it again?
@brillout I have updated on all your feedback. May I ask for a re-review?
@brillout > One (/ the only?) reason is that we need to use the URL instead of _pageId as cache key, because of parameterized routes. Thanks! CI passes now.