Joaquín Sánchez

Results 1398 comments of Joaquín Sánchez

@brc-dd I use this, LGTM: for example, I also apply some non blocking trick to css resources: https://github.com/vitest-dev/vitest/blob/main/docs/.vitepress/scripts/assets.ts#L40 @sanjaiyan-dev I use this with Link header (server side) to allow the...

> So it is already implemented in vitepress ? I think no, I should check the code... (my link is from Vitest docs)

> Can't we await Vite 3.1 for the object hook? I am still not a fan of having integration-specific logic built in. We need to do this way for SvelteKit...

included in the integration repo

@maifeeulasad check this https://developer.chrome.com/docs/workbox/modules/workbox-google-analytics/

@kevinmarrec I guess it is for webmanifest (`"manifest": The target is a manifest`, so it should be the webamnifest) https://developer.mozilla.org/en-US/docs/Web/API/Request/destination

@kevinmarrec cannot run example with instructions on readme file, it seems you've changed the layout (? missing package.json) and there are a lot of errors running it from root (running...

once the response interceptor is removed, a new exception is thrown (ClassCastException): GsonDeserializer cannot convert response from gituhub api to List<Repo>: (Android Studio 3.0.1: gradle plugin upgraded to 3.0.1) ![classcastexception](https://user-images.githubusercontent.com/6311119/35767246-2c763fa6-08e9-11e8-9ecc-d49e5ba3837e.png)

```java object ReposRemoteDataSource : ReposDataSource { init { FuelManager.instance.basePath = "https://api.github.com" // FuelManager.instance.addResponseInterceptor { loggingResponseInterceptor() } } internal val typeToken = object: TypeToken() {} internal class Deserializer : ResponseDeserializable {...

@awacode21 since you are using vite you can also check preset icons on unocss, your icons will go to your css, no more sfc for icons. Preset icons is also...