Joaquín Sánchez
Joaquín Sánchez
Add `svelte5.d.ts` to packages exports below this https://github.com/unplugin/unplugin-icons/blob/main/package.json#L112-L114
The example will require to update Svelte and some other dependencies (SvelteKit for example). We also need to update `examples/vite-svelte` dependencies.
`examples/sveltekit`: ```json "@sveltejs/kit": "^2.7.2", "@sveltejs/vite-plugin-svelte": "^4.0.0", "svelte": "^5.0.3", "svelte-check": "^4.0.5", ```
Yeah, in fact it is using Svelte 4, if you want to check it, just add a console.log below the version import with it and runnes flag: `console.log('Svelte version:', VERSION,...
`pnpm` lock file is missing in the PR and should be changed, doing weird things... Maybe we should add empty `pnpm-workspace.yaml` to both svelte examples and exclude them from the...
> I got the workspace examples working, as you noted it was the missing pnpm-lock - no idea what my pnpm install was doing! pnpm doing the same on my...
/cc @dominikg @benmccann can you review this :pray: when you have some free time?
@mattdavis90 can you check svelte compiler? maybe we can also remove the `ts-expect-error` (eslint should be complaining about that annotation)
We need to review svelte 5 dts, seems to be not working, there is no auto completion in vscode, svg attrs should be there.
> I can't find a better type for it. `Component` is the new type for components and expects `props` as the first generic which `SvelteHTMLElements['svg']` provides. Having said that you're...