Joaquín Sánchez
Joaquín Sánchez
> I would wish pkg-pr-new handles it automatically instead of us patching it I'm talking with @Aslemammad, this is a temporary patch here... maybe we can add some utility since...
The problem is about ignoring the package.json file when running `pnpm pack`, it is not being used and pkg-pr-new should merge the package.json dependencies with the generated by the pack...
https://github.com/stackblitz-labs/pkg.pr.new/pull/318
Looks good, I'm very busy at work, will check this in a few days, thx...
ok, maybe since `workbox-window` is missing and we're using svelte pwa virtual module, Vite/Kit unable to resolve the module since the virtual cannot load `workbox-window` and so the virtual module...
Check https://github.com/vite-pwa/sveltekit/issues/65#issuecomment-1734213190 For background sync you can use `backgroundSync` entry, something like this (not tested): ```js runtimeCaching: [{ urlPattern: /\/api\/.*\/*.json/, handler: 'NetworkFirst', //
Just one more note about `immediate`: it is only used to delay sw registration until document is loaded, check https://github.com/vite-pwa/workbox-window-es/blob/main/src/Workbox.ts#L111-L112 (workbox-window at wrokbox repo should be the same)
Async Function (RouteMatchCallback, RouteHandler, etc.) is not being included in the generated sw.js
You cannot use external functions, the code is serialized by workbox-build: you can use custom service worker (injectManifest strategy) or inline any function call
This PR should be breaking, we need to redirect `types/svelte.d.ts` to `types/svelte5.d.ts` adding `types/svelte5.d.ts` to the package.json exports entry, just below `types/svelte4.d.ts`. We also need: - add entry in README...
Yeah, I just merged Svelte 5 support a few minutes ago in main branch (I mean the PR about adding svelte 5 in supported versions)