Martin Schuhfuss

Results 211 comments of Martin Schuhfuss

First off, thanks a lot for your work – I really appreciate you taking the time to jump into it. However, it would have been good to open a feature...

As for legacy applications, that is exactly why the parameter is still working. The "standardizing" bit about apiKeys is exactly what has happened by now, and there is no longer...

The id prop of the map was never intended to be used this way, but I can totally understand your expectation. I'll have to think if there'll be any negative...

The div is created here: https://github.com/visgl/react-google-maps/blob/bed6ccd31911ac82decc758bd4ecee0a18fe492f/src/components/map/index.tsx#L228-L241 So, we could probably just add the id to that div-element there when an id is specified. That shouldn't interfere with anything else, and...

Ah, I forgot about the extra div we created to be able to unmount and remount map instances. I think the id should only be added to the mapDiv itself,...

@LeLunZ Thanks for the work! I would like to integrate this for the next release, are you still up to continue working on this or should I just take it...

I'm open to making this change, with a tendency towards inlining a simple implementation of what we actually need into our library to avoid external dependencies altogether. But to clarify,...

I appreciate the thoughts and the time you invested! The documentation is certainly still in need of some more refinement and you point out an important topic we can do...

We will have to add this with the next major version, as this is a breaking change.

Thanks for bringing that up – we should address that ASAP. But I can't find a reference to passing the token via a query parameter in the documentation. In [step...