js-markerclusterer icon indicating copy to clipboard operation
js-markerclusterer copied to clipboard

Correct exports of the module

Open trygve-lie opened this issue 1 year ago • 3 comments

Correct exports of the module for better module loading compatibility with node.js.


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [x] Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • [x] Ensure the tests and linter pass
  • [x] Code coverage does not decrease (if any source code was changed)
  • [x] Appropriate docs were updated (if necessary)

Fixes #908 🦕

trygve-lie avatar Aug 12 '24 21:08 trygve-lie

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 12 '24 21:08 google-cla[bot]

We will have to add this with the next major version, as this is a breaking change.

usefulthink avatar Jan 15 '25 18:01 usefulthink

@usefulthink Great :+1: Any thoughts on when a new major might happen?

trygve-lie avatar Apr 21 '25 16:04 trygve-lie