carma-platform icon indicating copy to clipboard operation
carma-platform copied to clipboard

Package manifest files list non-existent package as a dependency

Open adamlm opened this issue 1 year ago • 0 comments

Summary

Several CARMA packages list a non-existent ROS package as a dependency in the package.xml files. They list ament_auto_cmake, but they should list ament_cmake_auto. This issue was most likely not found because the test and deployment environments already have ament_cmake_auto installed, so the find_package(ament_cmake_auto REQUIRED) CMake command worked.

Note: I am not sure what ament_auto's policy is for when it finds non-existent packages in a package.xml. Based on this bug, I assume it silently ignores thems.

Affected packages:

  • gnss_to_map_convertor
  • localization_manager
  • platooning_strategic_IHP
  • bsm_generator
  • trajectory_executor
  • light_controlled_intersection_tactical_plugin
  • frame_transformer
  • object_detection_tracking
  • stop_and_dwell_strategic_plugin
  • yield_plugin
  • route_following_plugin
  • route
  • template_package
  • cooperative_lanechange
  • mobilitypath_publisher
  • approaching_emergency_vehicle_plugin
  • plan_delegator
  • platooning_tactical_plugin
  • port_drayage_plugin
  • lightbar_manager
  • guidance
  • motion_prediction_visualizer
  • motion_computation
  • approximate_intersection
  • basic_autonomy
  • carma_wm_ctrl
  • trajectory_visualizer
  • arbitrator
  • subsystem_controllers
  • mobilitypath_visualizer
  • stop_controlled_intersection_tactical_plugin
  • carma_guidance_plugins
  • object_visualizer
  • roadway_objects
  • points_map_filter
  • stop_and_wait_plugin
  • sci_strategic_plugin
  • carma_wm
  • pose_to_tf
  • carma_cloud_client
  • traffic_incident_parser
  • lci_strategic_plugin
  • pure_pursuit_wrapper
  • inlanecruising_plugin

Version

4.3.0 (Current)

Expected Behavior

Relevant CARMA packages depend on ament_cmake_auto.

Actual Behavior

Relevant CARMA packages depend on ament_auto_cmake.

Steps to Reproduce the Actual Behavior

  1. Clone the carma-system-4.4.2 branch:

    $ git clone --branch carma-system-4.4.2 https://github.com/usdot-fhwa-stol/carma-platform.git
    
  2. Run grep for ament_auto_cmake inside the repository:

    $ grep -R ament_auto_cmake .
    

Related Work

No response

adamlm avatar Sep 14 '23 14:09 adamlm