carma-platform
carma-platform copied to clipboard
Circle CI is not failing the PR even after detecting unit test failures
Types of Issue
- [X] Anomaly report (something appears to not work correctly)
- [ ] Enhancement request (describe the enhancement being requested)
- [ ] Other (please ensure the description clarifies why the issue doesn’t fall into either of the above categories)
Descriptive summary
- When scrolling through the unit test workflow, the CircleCi is not failing the PRs with unit test failures.
- Also we noticed some unit tests are not being detected at all (0% coverage) by Sonar.
https://app.circleci.com/pipelines/github/usdot-fhwa-stol/carma-platform/3297/workflows/355d3b6c-64bd-49ab-9365-e9361e29f34e/jobs/3439
Examples are:
etc. The developer should find all those remaining and resolve it.
Carma version where this issue was discovered
carma-platform develop 3.4.0 +
Expected behavior
there should be no unit test failures.
Actual behavior
unit tests fail not CircleCi doesn't detect it. new unit tests sometimes are not detected by sonar.
Steps to reproduce the actual behavior
Put up a PR and see CircleCI, Sonar reports.