Mason Mackaman

Results 43 comments of Mason Mackaman

It looks like there's a bug where if you already have the dependency checked out and you put in `"master"` to try to update to the latest commit, it won't...

You know, I can't say. I've been away from this for quite some time now lol.

I'm having the same problem.

I was simply just trying to add some weight behind this issue, but sure, I'll give my info * Termux application version: 0.118.0, F-Droid * Android OS version: 11 -...

That doesn't explain why any of the tests I've made aren't included in that list.

Given #77 was just closed. I think the reasoning should definitely be explained clearly. 👍

the following code can be added to the end of the `main` function in [simple-circuit.rs](https://github.com/zcash/halo2/blob/9617336d46a18f3949260731d02bd711fba9d863/halo2_proofs/examples/simple-example.rs) to demonstrate this error. ```rust use halo2_proofs::{ plonk::{create_proof, keygen_pk, keygen_vk, VerifyingKey}, poly::commitment::Params, transcript::Blake2bWrite, }; use...

Possible helpful info: If you change [this line](https://github.com/zcash/halo2/blob/9617336d46a18f3949260731d02bd711fba9d863/halo2_proofs/examples/simple-example.rs#L116) to `vec![(lhs * rhs - out)]` (and comment out the assertions from the MockProver section), you will no longer get any errors.

[The code that is supposed to test this](https://github.com/zcash/halo2/blob/9617336d46a18f3949260731d02bd711fba9d863/halo2_proofs/tests/plonk_api.rs#L535-L543) is used on a circuit that has [no selectors](https://github.com/zcash/halo2/blob/9617336d46a18f3949260731d02bd711fba9d863/halo2_proofs/tests/plonk_api.rs#L578)

I'm new enough that I remember reading that for the first time in the documentation. I enjoyed it :) so I vote keep as well.