Urmas Talimaa

Results 6 comments of Urmas Talimaa

The build fails because of `sh: 1: grunt: not found` by the way.

I added a check to avoid a rpc, as the aliveness check is necessary for only local processes: https://github.com/ostinelli/syn/compare/872f137c5da0fc4978e1e6fe545b33c058ca09f6..4e1b194012e8be6b0253375c2dd9a4b4196cda41

Hi! When you have a chance, could you please re-review?

If you think it better aligns with the overall design, I could insert a case to https://github.com/kafka4beam/kafka_protocol/pull/119/files#diff-d0ce76e3ce9ae92f1e08fbcba270b20ae72e252c2c1fb716e0074e05812aebb7R293 where if the response if `{ok, SaslResponse}` and the session lifetime within the...

Just FYI, it will take me a few days to get back to this PR.

Implemented the suggestions in a [new PR](https://github.com/kafka4beam/kafka_protocol/pull/122) as the diff drifted substantially from the initial proposal.