g2opy icon indicating copy to clipboard operation
g2opy copied to clipboard

Cannot make build on macosx

Open imranq opened this issue 5 years ago • 11 comments

It seems to be an issue with Eigen, but I cannot get this package to install:

n file included from /Volumes/IQSD/Projects/twitchslam-master/g2opy/python/g2o.cpp:1: In file included from /Volumes/IQSD/Projects/twitchslam-master/g2opy/EXTERNAL/pybind11/include/pybind11/pybind11.h:43: In file included from /Volumes/IQSD/Projects/twitchslam-master/g2opy/EXTERNAL/pybind11/include/pybind11/attr.h:13: In file included from /Volumes/IQSD/Projects/twitchslam-master/g2opy/EXTERNAL/pybind11/include/pybind11/cast.h:16: /Volumes/IQSD/Projects/twitchslam-master/g2opy/EXTERNAL/pybind11/include/pybind11/detail/internals.h:82:14: warning: 'PyThread_create_key' is deprecated [-Wdeprecated-declarations] decltype(PyThread_create_key()) tstate = 0; // Usually an int but a ... ^ /Library/Frameworks/Python.framework/Versions/3.7/include/python3.7m/pythread.h:95:17: note: 'PyThread_create_key' has been explicitly marked deprecated here PyAPI_FUNC(int) PyThread_create_key(void) Py_DEPRECATED(3.7); ^ In file included from /Volumes/IQSD/Projects/twitchslam-master/g2opy/python/g2o.cpp:1: In file included from /Volumes/IQSD/Projects/twitchslam-master/g2opy/EXTERNAL/pybind11/include/pybind11/pybind11.h:43: In file included from /Volumes/IQSD/Projects/twitchslam-master/g2opy/EXTERNAL/pybind11/include/pybind11/attr.h:13: In file included from /Volumes/IQSD/Projects/twitchslam-master/g2opy/EXTERNAL/pybind11/include/pybind11/cast.h:16: /Volumes/IQSD/Projects/twitchslam-master/g2opy/EXTERNAL/pybind11/include/pybind11/detail/internals.h:167:33: warning: 'PyThread_create_key' is deprecated [-Wdeprecated-declarations] internals_ptr->tstate = PyThread_create_key(); ^ /Library/Frameworks/Python.framework/Versions/3.7/include/python3.7m/pythread.h:95:17: note: 'PyThread_create_key' has been explicitly marked deprecated here PyAPI_FUNC(int) PyThread_create_key(void) Py_DEPRECATED(3.7); ^ In file included from /Volumes/IQSD/Projects/twitchslam-master/g2opy/python/g2o.cpp:1: In file included from /Volumes/IQSD/Projects/twitchslam-master/g2opy/EXTERNAL/pybind11/include/pybind11/pybind11.h:43: In file included from /Volumes/IQSD/Projects/twitchslam-master/g2opy/EXTERNAL/pybind11/include/pybind11/attr.h:13: In file included from /Volumes/IQSD/Projects/twitchslam-master/g2opy/EXTERNAL/pybind11/include/pybind11/cast.h:16: /Volumes/IQSD/Projects/twitchslam-master/g2opy/EXTERNAL/pybind11/include/pybind11/detail/internals.h:168:9: warning: 'PyThread_set_key_value' is deprecated [-Wdeprecated-declarations] PyThread_set_key_value(internals_ptr->tstate, tstate); ^ /Library/Frameworks/Python.framework/Versions/3.7/include/python3.7m/pythread.h:97:17: note: 'PyThread_set_key_value' has been explicitly marked deprecated here PyAPI_FUNC(int) PyThread_set_key_value(int key, void *value) Py_DEPRECATED(3.7); ^ In file included from /Volumes/IQSD/Projects/twitchslam-master/g2opy/python/g2o.cpp:1: /Volumes/IQSD/Projects/twitchslam-master/g2opy/EXTERNAL/pybind11/include/pybind11/pybind11.h:1741:36: warning: 'PyThread_get_key_value' is deprecated [-Wdeprecated-declarations] tstate = (PyThreadState *) PyThread_get_key_value(internals.tstate); ^ /Library/Frameworks/Python.framework/Versions/3.7/include/python3.7m/pythread.h:98:20: note: 'PyThread_get_key_value' has been explicitly marked deprecated here PyAPI_FUNC(void *) PyThread_get_key_value(int key) Py_DEPRECATED(3.7); ^ In file included from /Volumes/IQSD/Projects/twitchslam-master/g2opy/python/g2o.cpp:1: /Volumes/IQSD/Projects/twitchslam-master/g2opy/EXTERNAL/pybind11/include/pybind11/pybind11.h:1753:13: warning: 'PyThread_set_key_value' is deprecated [-Wdeprecated-declarations] PyThread_set_key_value(internals.tstate, tstate); ^ /Library/Frameworks/Python.framework/Versions/3.7/include/python3.7m/pythread.h:97:17: note: 'PyThread_set_key_value' has been explicitly marked deprecated here PyAPI_FUNC(int) PyThread_set_key_value(int key, void *value) Py_DEPRECATED(3.7); ^ In file included from /Volumes/IQSD/Projects/twitchslam-master/g2opy/python/g2o.cpp:1: /Volumes/IQSD/Projects/twitchslam-master/g2opy/EXTERNAL/pybind11/include/pybind11/pybind11.h:1792:13: warning: 'PyThread_delete_key_value' is deprecated [-Wdeprecated-declarations] PyThread_delete_key_value(detail::get_internals().tstate); ^ /Library/Frameworks/Python.framework/Versions/3.7/include/python3.7m/pythread.h:99:18: note: 'PyThread_delete_key_value' has been explicitly marked deprecated here PyAPI_FUNC(void) PyThread_delete_key_value(int key) Py_DEPRECATED(3.7); ^ In file included from /Volumes/IQSD/Projects/twitchslam-master/g2opy/python/g2o.cpp:1: /Volumes/IQSD/Projects/twitchslam-master/g2opy/EXTERNAL/pybind11/include/pybind11/pybind11.h:1820:17: warning: 'PyThread_set_key_value' is deprecated [-Wdeprecated-declarations] PyThread_set_key_value(key, nullptr); ^ /Library/Frameworks/Python.framework/Versions/3.7/include/python3.7m/pythread.h:97:17: note: 'PyThread_set_key_value' has been explicitly marked deprecated here PyAPI_FUNC(int) PyThread_set_key_value(int key, void *value) Py_DEPRECATED(3.7); ^ In file included from /Volumes/IQSD/Projects/twitchslam-master/g2opy/python/g2o.cpp:1: /Volumes/IQSD/Projects/twitchslam-master/g2opy/EXTERNAL/pybind11/include/pybind11/pybind11.h:1833:13: warning: 'PyThread_set_key_value' is deprecated [-Wdeprecated-declarations] PyThread_set_key_value(key, tstate); ^ /Library/Frameworks/Python.framework/Versions/3.7/include/python3.7m/pythread.h:97:17: note: 'PyThread_set_key_value' has been explicitly marked deprecated here PyAPI_FUNC(int) PyThread_set_key_value(int key, void *value) Py_DEPRECATED(3.7); ^ In file included from /Volumes/IQSD/Projects/twitchslam-master/g2opy/python/g2o.cpp:12: /Volumes/IQSD/Projects/twitchslam-master/g2opy/python/core/eigen_types.h:185:62: error: address of overloaded function 'x' does not match required type 'double () const' ...(double (Eigen::Quaterniond::*) () const) &Eigen::Quaterniond::x) ^~~~~~~~~~~~~~~~~~~~~ /usr/local/include/eigen3/Eigen/src/Geometry/Quaternion.h:66:44: note: candidate function has different return type ('double' expected but has 'CoeffReturnType' (aka 'const double &')) EIGEN_DEVICE_FUNC inline CoeffReturnType x() const { return this->deri... ^ /usr/local/include/eigen3/Eigen/src/Geometry/Quaternion.h:75:52: note: candidate function has different return type ('double' expected but has 'NonConstCoeffReturnType' (aka 'double &')) EIGEN_DEVICE_FUNC inline NonConstCoeffReturnType x() { return this->de... ^ In file included from /Volumes/IQSD/Projects/twitchslam-master/g2opy/python/g2o.cpp:12: /Volumes/IQSD/Projects/twitchslam-master/g2opy/python/core/eigen_types.h:186:62: error: address of overloaded function 'y' does not match required type 'double () const' ...(double (Eigen::Quaterniond::*) () const) &Eigen::Quaterniond::y) ^~~~~~~~~~~~~~~~~~~~~ /usr/local/include/eigen3/Eigen/src/Geometry/Quaternion.h:68:44: note: candidate function has different return type ('double' expected but has 'CoeffReturnType' (aka 'const double &')) EIGEN_DEVICE_FUNC inline CoeffReturnType y() const { return this->deri... ^ /usr/local/include/eigen3/Eigen/src/Geometry/Quaternion.h:77:52: note: candidate function has different return type ('double' expected but has 'NonConstCoeffReturnType' (aka 'double &')) EIGEN_DEVICE_FUNC inline NonConstCoeffReturnType y() { return this->de... ^ In file included from /Volumes/IQSD/Projects/twitchslam-master/g2opy/python/g2o.cpp:12: /Volumes/IQSD/Projects/twitchslam-master/g2opy/python/core/eigen_types.h:187:62: error: address of overloaded function 'z' does not match required type 'double () const' ...(double (Eigen::Quaterniond::*) () const) &Eigen::Quaterniond::z) ^~~~~~~~~~~~~~~~~~~~~ /usr/local/include/eigen3/Eigen/src/Geometry/Quaternion.h:70:44: note: candidate function has different return type ('double' expected but has 'CoeffReturnType' (aka 'const double &')) EIGEN_DEVICE_FUNC inline CoeffReturnType z() const { return this->deri... ^ /usr/local/include/eigen3/Eigen/src/Geometry/Quaternion.h:79:52: note: candidate function has different return type ('double' expected but has 'NonConstCoeffReturnType' (aka 'double &')) EIGEN_DEVICE_FUNC inline NonConstCoeffReturnType z() { return this->de... ^ In file included from /Volumes/IQSD/Projects/twitchslam-master/g2opy/python/g2o.cpp:12: /Volumes/IQSD/Projects/twitchslam-master/g2opy/python/core/eigen_types.h:188:62: error: address of overloaded function 'w' does not match required type 'double () const' ...(double (Eigen::Quaterniond::*) () const) &Eigen::Quaterniond::w) ^~~~~~~~~~~~~~~~~~~~~ /usr/local/include/eigen3/Eigen/src/Geometry/Quaternion.h:72:44: note: candidate function has different return type ('double' expected but has 'CoeffReturnType' (aka 'const double &')) EIGEN_DEVICE_FUNC inline CoeffReturnType w() const { return this->deri... ^ /usr/local/include/eigen3/Eigen/src/Geometry/Quaternion.h:81:52: note: candidate function has different return type ('double' expected but has 'NonConstCoeffReturnType' (aka 'double &')) EIGEN_DEVICE_FUNC inline NonConstCoeffReturnType w() { return this->de... ^

imranq avatar Sep 02 '18 20:09 imranq

Also here is a picture for better readability screen shot 2018-09-02 at 4 32 23 pm

imranq avatar Sep 02 '18 20:09 imranq

I think you need to have Eigen3 installed. On Linux I just installed libeigen3-dev through the Ubuntu repository.

For Mac, try following the suggestion from this post:

https://stackoverflow.com/questions/35658420/installing-eigen-on-mac-os-x-for-xcode

plasticuproject avatar Sep 03 '18 07:09 plasticuproject

Thanks! I think Eigen is installed but there’s something wrong with the way c++ compiles on my machine

imranq avatar Sep 04 '18 21:09 imranq

I'm having the same problem, and I have Eigen3 installed. @plasticuproject Went to the linked post and still nothing. Can anybody help?

mattmilne avatar Feb 08 '19 22:02 mattmilne

I am having this exact issue as well. I have installed eigen via homebrew as well as manually building it and cannot figure it out.

bobrown101 avatar Feb 21 '19 02:02 bobrown101

I am having this exact issue as well. I have installed eigen via homebrew as well as manually building it and cannot figure it out.

One of the pull requests addresses this issue.

mattmilne avatar Feb 21 '19 06:02 mattmilne

I am also in trouble with the same problem. Eigen::Quaterniond complains many times.

ghost avatar Mar 16 '19 03:03 ghost

Having the same issue, is there an update on the solution?

ChenHoy avatar Oct 10 '19 09:10 ChenHoy

The maintainer of this repo hasn't been active since Jan 2018. It's essentially dead. I have a fork on my account, that I forked from the original RainerKuemmerle/g2o and then added uoip's changes (this way you can view and compare code, history and commits) if anyone is interested in writing some PRs to fix some of the issues.

plasticuproject avatar Oct 11 '19 01:10 plasticuproject

@ChenHoy @petroskey I added the code from PR #16 to my fork, that may fix your problem.

plasticuproject avatar Oct 11 '19 02:10 plasticuproject

Thank you for your help! I included the fix and got it working now. -------- Ursprüngliche Nachricht --------Von: plasticuproject [email protected] Datum: 11.10.19 04:50 (GMT+01:00) An: uoip/g2opy [email protected] Cc: ChenHoy [email protected], Mention [email protected] Betreff: Re: [uoip/g2opy] Cannot make build on macosx (#10) @ChenHoy @petroskey I added the code from PR #16 to my fork, that may fix your problem.

—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe. [ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/uoip/g2opy/issues/10?email_source=notifications\u0026email_token=AI45MKNB4KRSSGQPHWIQCZDQN7SYBA5CNFSM4FS3AG62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA6SH4Y#issuecomment-540877811", "url": "https://github.com/uoip/g2opy/issues/10?email_source=notifications\u0026email_token=AI45MKNB4KRSSGQPHWIQCZDQN7SYBA5CNFSM4FS3AG62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA6SH4Y#issuecomment-540877811", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

ChenHoy avatar Oct 11 '19 04:10 ChenHoy