Markus Unterwaditzer
Markus Unterwaditzer
@fpacifici thanks for the thorough review and for keeping coding standards high. I think I have addressed all review comments. I can split up the PR. Should I do this...
I split up the PR into five different ones and edited the PR description to reflect in which order they need to be merged. After that I'll rebase this PR...
Regarding relying on optparse not being a good idea: > click is actually implemented as a wrapper around optparse and does not implement any parsing itself. The reason it’s not...
In Firefox, `History.replaceState` doesn't remove the entry from the browser history, but only from the "tab history".
It seems to work in Chromium though, so this might be a browser bug actually.
Meh, it seems I can grep the access token from the sqlite database in Chromium. Maybe it's just some stuff that will soon get GC'd, but I'm not sure.
You mean in an actual popup, or an absolutely positioned iframe? (is the latter even possible)
I wonder whether running the OAuth dialog in an iframe overlay is possible. afaict this would prevent writing anything into history in the first place (as opposed to removing the...
Though this probably would open the door for a lot of attacks by malicious apps. On 13 October 2015 15:43:02 CEST, Sebastian Kippe [email protected] wrote: > Oh wow, talk about...
My point is that I must be able to specify whether I intend to overwrite a file or not, because anything else leads to races. On 8 September 2015 12:04:47...