unsloth icon indicating copy to clipboard operation
unsloth copied to clipboard

EOS_TOKEN = tokenizer.eos_token not working for unsloth/llama-3-8b-Instruct-bnb-4bit

Open burgerbee opened this issue 10 months ago • 4 comments

Looks like we are getting the wrong EOS_TOKEN and endless generation for the Llama 3 Instruct variant.

burgerbee avatar Apr 25 '24 20:04 burgerbee

@burgerbee The EOS token seems correct no? image

Also the generation config: image

I did update the models, so you might have to re download them

danielhanchen avatar Apr 26 '24 10:04 danielhanchen

The example code in the notebook https://colab.research.google.com/drive/135ced7oHytdxu3N2DNe1Z0kqjyYIkDXp?usp=sharing works with unsloth/llama-3-8b-bnb-4bit but changing to unsloth/llama-3-8b-Instruct-bnb-4bit gives endless generation.

Will delete model, pip install --upgrade --force-reinstall --no-cache-dir and try again.

burgerbee avatar Apr 26 '24 11:04 burgerbee

this is what mstudio team was think it is

Because LM studio defaults to the proper template for that. So in this case, manually select the Llama 3 preset ... if it's still broken when using the right template, the fine tune could be messed up in that it removed the stop Tokens (<|eot_id|>)

Tonic3 avatar Apr 26 '24 16:04 Tonic3

Hmm interesting on LM Studio

danielhanchen avatar Apr 28 '24 18:04 danielhanchen