unsloth icon indicating copy to clipboard operation
unsloth copied to clipboard

Window Support Fix--Update pyproject.toml

Open Datbwoyyy opened this issue 9 months ago • 5 comments

Fixes & Improvements: I Removed Duplicate [build-system] Sections: The [build-system] section was defined multiple times, which could cause conflicts.

Ensure Triton is Available for Windows: Triton doesn't officially support Windows. So i included prebuilt wheels from woct0rdho/triton-windows

Also ensured Windows-Specific bitsandbytes Handling

Datbwoyyy avatar Feb 18 '25 10:02 Datbwoyyy

Why are there deletions of dependencies?

danielhanchen avatar Feb 18 '25 11:02 danielhanchen

I made changes to the pyproject.toml file to ensure compatibility across both Windows and Linux environments. Specifically, I handled the platform-specific dependencies to ensure that the right versions of libraries are installed depending on the system. For Windows, I’ve ensured that bitsandbytes-windows and a Windows-compatible version of triton are included, as these are specifically tailored for Windows. For Linux, the original bitsandbytes and triton versions are used.

I will Check again to ensure the deleted Dependencies are added Back sorry for the mistake.

On Tue, Feb 18, 2025 at 12:24 PM Daniel Han @.***> wrote:

Why are there deletions of dependencies?

— Reply to this email directly, view it on GitHub https://github.com/unslothai/unsloth/pull/1748#issuecomment-2665370455, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7URL3YYMRDBD7ADMPLMDTD2QMJ7TAVCNFSM6AAAAABXLIJFSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRVGM3TANBVGU . You are receiving this because you authored the thread.Message ID: @.***> [image: danielhanchen]danielhanchen left a comment (unslothai/unsloth#1748) https://github.com/unslothai/unsloth/pull/1748#issuecomment-2665370455

Why are there deletions of dependencies?

— Reply to this email directly, view it on GitHub https://github.com/unslothai/unsloth/pull/1748#issuecomment-2665370455, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7URL3YYMRDBD7ADMPLMDTD2QMJ7TAVCNFSM6AAAAABXLIJFSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRVGM3TANBVGU . You are receiving this because you authored the thread.Message ID: @.***>

Datbwoyyy avatar Feb 18 '25 11:02 Datbwoyyy

Fixed! Yes they were and they were duly referenced check my read me. Ai gave me a start point and I refined some steps . Hence the issue.

On Fri, 21 Feb 2025 at 08:05, Kareem @.***> wrote:

Why are there deletions of dependencies?

All of the PRs created by this person are AI generated

— Reply to this email directly, view it on GitHub https://github.com/unslothai/unsloth/pull/1748#issuecomment-2673751056, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7URL36VEWBUR4F75V5V3LL2Q3F43AVCNFSM6AAAAABXLIJFSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZTG42TCMBVGY . You are receiving this because you authored the thread.Message ID: @.***> [image: KareemMusleh]KareemMusleh left a comment (unslothai/unsloth#1748) https://github.com/unslothai/unsloth/pull/1748#issuecomment-2673751056

Why are there deletions of dependencies?

All of the PRs created by this person are AI generated

— Reply to this email directly, view it on GitHub https://github.com/unslothai/unsloth/pull/1748#issuecomment-2673751056, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7URL36VEWBUR4F75V5V3LL2Q3F43AVCNFSM6AAAAABXLIJFSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZTG42TCMBVGY . You are receiving this because you authored the thread.Message ID: @.***>

Datbwoyyy avatar Feb 21 '25 07:02 Datbwoyyy

Apologies this is incorrect sorry!

danielhanchen avatar Feb 23 '25 23:02 danielhanchen

No problem, thanks!,I have rectified it also… I made a fix in which bits and bytes and all other pip install function tools worked…but triton still don’t work in a window space except using WSL2 should I commit that?

On Mon, 24 Feb 2025 at 00:30, Daniel Han @.***> wrote:

Apologies this is incorrect sorry!

— Reply to this email directly, view it on GitHub https://github.com/unslothai/unsloth/pull/1748#issuecomment-2677180481, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7URL34BEMKW2FFGYRZULGL2RJK2XAVCNFSM6AAAAABXLIJFSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZXGE4DANBYGE . You are receiving this because you authored the thread.Message ID: @.***> [image: danielhanchen]danielhanchen left a comment (unslothai/unsloth#1748) https://github.com/unslothai/unsloth/pull/1748#issuecomment-2677180481

Apologies this is incorrect sorry!

— Reply to this email directly, view it on GitHub https://github.com/unslothai/unsloth/pull/1748#issuecomment-2677180481, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7URL34BEMKW2FFGYRZULGL2RJK2XAVCNFSM6AAAAABXLIJFSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZXGE4DANBYGE . You are receiving this because you authored the thread.Message ID: @.***>

Datbwoyyy avatar Feb 24 '25 03:02 Datbwoyyy