unfold

unfold copied to clipboard

Probably minor issue: repeated elseif with same condition

1

Hi Bene and Olaf, I just noticed that cfg.method if-block within uf_glmfit function has two times 'matlab' and two times 'pinv' with slightly different code. https://github.com/unfoldtoolbox/unfold/blob/caa07fdf1a881a5c31705898392df3f699461aff/src/uf_toolbox/uf_glmfit.m#L125 https://github.com/unfoldtoolbox/unfold/blob/caa07fdf1a881a5c31705898392df3f699461aff/src/uf_toolbox/uf_glmfit.m#L201 https://github.com/unfoldtoolbox/unfold/blob/caa07fdf1a881a5c31705898392df3f699461aff/src/uf_toolbox/uf_glmfit.m#L133 https://github.com/unfoldtoolbox/unfold/blob/caa07fdf1a881a5c31705898392df3f699461aff/src/uf_toolbox/uf_glmfit.m#L210 The...

chsquare

MartynaPlomecka

as part of creating the design matrix with `uf_designmat`, unfold checks the rank of the design matrix and gives out a warning if the rank is smaller than the number...

olafdimigen

Bad behavior if letter case of eventtype name is incorrect (in cfg.eventypes)

3

`uf_designmat` looks for 'eventstypes' but using `strcmpi()`, which ignores case. Thus, when an event is specified with a wrong case, e.g. ` cfgDesign.eventtypes = {'sTiMuLuSoNsEt'} % should be 'stimulusOnset' `...

olafdimigen

Documentation Todo

3

- [x] Remove Permalink Icon - [ ] Fix some formation issues for autodoc (e.g. uf_addmarginal) - [ ] code-examples in API should be code-block style, then you can ctrl+c...

behinger

Pulling unfold still include the buggy EEGVIS toolbox version, which has, e.g., the "MinorTicks" incompatibility issue.

olafdimigen

uf_checkmodelfit does not work with glmnet due to extra variablename "glm-DC correction"

1

`uf_checkmodelfit` does not work with `glmnet` due to extra variablename "glm-DC correction" (Found this bug in my notes, added it here just as a future todo list point.)

olafdimigen

uf_designMat should throw an error when EEG.event.type is empty

1

Currently it is just crashing.

behinger

MATLAB crashing during uf_glmfit when glmnet method is used

5

MATLAB version: R2017b I have encounter a fatal error when running uf_glmfit with glmnet method. E.g. EEG= uf_glmfit(EEG,'method','glmnet'); The error message referred to Access Violation, and the error was detected...

anikokusztor

If one selects a beta-field in uf_addmarignal, then only that field gets the marginal added, but not the other. e.g. ufresult.beta .beta_nodc specified with 'betasetname','beta' will result in ufresult.beta+marginal .beta_nodc...

behinger