Umut Canbolat

Results 15 comments of Umut Canbolat

Good to hear something back. Take your time, and feel free to leave some comments when you are available. Best!

I recommend hiding the whitespace changes while reviewing. Otherwise, the change of indentation makes it look like the whole file is edited. ![image](https://user-images.githubusercontent.com/10065235/97097863-7cc26a00-1676-11eb-8b1d-99b458bca8d1.png)

Hi, I think using async-await here makes it more readable. But we can consider this in another PR as you suggested. So, with Promise chaining, it would look like this:...

I didn't have time this weekend, but I will resolve conflicts and do the changes during the next week. Best!

Hi again. Rebased into master and converted the async-await logic back to the promise chaining as you asked to discuss this in a separate PR. Have a nice week!

Hi! I will investigate the issues when I find some time. Until then, I am labeling this as help wanted. Thanks.

For newcomers, this is an issue of the API: [instant-username-search-api](https://github.com/instant-username-search/instant-username-search-api)

Hi, @catnbyte. The backend API is in a very bad need for maintenance. I couldn't spend time on it for a while but soon I will be checking every service...

@sanjitchak dev environment uses a mock service that returns random results.