Ulugbek Abdullaev

Results 116 comments of Ulugbek Abdullaev

Since we're creating a new request there should be no harm in keeping the state on the server side. I would hate for every client to have to implement the...

My poor familiarity with windows -- l will send a fix. I wish we used ocaml-uri though

This will only be fixed when merlin adds support for global reference search. This is on the merlin’s roadmap, AFAIK.

> Improve ocamlc-loc to understand this particular error better But is ocamlc-loc intended to recognize merlin errors (which seem to be different from compiler ones in some cases) For example,...

You can look at merlin tests to see how to run an occurrences query on merlin, e.g., `ocamlmerlin single occurrences -identifier-at 1:11 -filename ./basic.ml < ./basic.ml`. See this https://github.com/ocaml/merlin/tree/master/tests/test-dirs/occurrences I...

> It's an improvement, but it's a bit of a shame it has to be done this way. Have you considered the following solution: Do you mean submitting a patch...

Is it worth merging this PR before we make a PR to ofmt and they release a new version? It's a big QoL improvement imho

If no one has started working on this, I can give it a shot next week.

I think @roddyyaga meant that compiler does provide such hints, but ocaml-lsp doesn't. I checked with merlin, they also provide hints, so we should be able to add them to...

The name of the variable doesn’t reflect the underlying lsp token type we use. Its value (which is 0) is the index in Token_type.list, which should be “namespace.” Does this...