Alex H comments

Results 14 comments of


                                            Alex H

Consider using `lto="thin"`

I did some additional testing with the knowledge that ThinLTO splitting is dependent on `codegen-units`. Setting `codegen-units = 2` with `lto = "thin"` results in a 17mb binary and takes...

(clap_complete) Make `Shell` ValueEnum Parser also Accept $SHELL Output (Path Prefixed Shell Names)

Uh, this is not actually a duplicate of that issue? That issue adds a method to implicitly parse Shell from the env, but does not add it to the ValueEnum...

(clap_complete) Make `Shell` ValueEnum Parser also Accept $SHELL Output (Path Prefixed Shell Names)

Yeah, I see that was closed as not planned, but that was because it was reading the env, no? The proposed implementation here would be so that users may pass...

(clap_complete) Make `Shell` ValueEnum Parser also Accept $SHELL Output (Path Prefixed Shell Names)

If the conclusion here is that the implicit Shell::from_env method should be used, then thats fine, but personally I dont like reading env vars without being obvious about it, and...

(clap_complete) Make `Shell` ValueEnum Parser also Accept $SHELL Output (Path Prefixed Shell Names)

> If we go this route, it isn't as simple as putting this in the `FromStr`. We'd have to write a custom `TypedValueParser` impl as that is what is used...

Add method to get full match from `Captures`

A potential other name could be `as_match`

Folder Name not Sanitized Before Passing to Matcher v2

still a bug, not stale

Folder Name not Sanitized Before Passing to Matcher v2

still a bug, not stale

Folder Name not Sanitized Before Passing to Matcher v2

not stale.

Folder Name not Sanitized Before Passing to Matcher v2

see previous messages