Ulrich Thiel
Ulrich Thiel
Have it as is, because that's exactly why I've written it. :-) Improvements welcome of course.
> Could you click "resolve conversation" on all comments above once you addressed them? This makes it way easier to keep an overview here. Yes, once addressed... ;-)
> If you change the Hecke version in the file `Oscar/src/Project.toml` to `0.30.2`, you should be able to get rid of `complex_conjugation2`. Excellent. I will when I'm done (ETA next...
> If you change the Hecke version in the file `Oscar/src/Project.toml` to `0.30.2`, you should be able to get rid of `complex_conjugation2`. Done in [efbb6e5](https://github.com/oscar-system/Oscar.jl/pull/3342/commits/efbb6e539f6bb7adc6f90fd6f035083bfbe4a3cb).
Can someone (@joschmitt @lgoettgens) help me with the failing tests? This seems to be a problem with experimental/LieAlgebras and the function coroot, which I have implemented (with a different signature)...
Thanks, let's see if it works.
Ok, checks passed finally. I will need to document the functions, add further documentation, and address the stuff from the top of this conversation. Then it should be OK for...
Okay thanks all. I'll need a bit to address everything...
What is this failing invalidations?
> This is still marked as "draft". @ulthiel what is missing from your POV before this can be merged? > > I worry a bit about drift happening to this...