Ülgen Sarıkavak

Results 269 comments of Ülgen Sarıkavak

@thibaudcolas https://github.com/django/djangoproject.com/pull/2212#discussion_r2423117523 is still waiting for input from group members. I believe @dvarrazzo 's last comment on the thread provided a couple of points that may affect the overall decision.

I'm not sure this is desired. pre-commit hooks don't require any dependency that is handled with the container setup, and I believe the standard/common practice is to keep anything git...

> which a few of us tried to do at a recent sprint Sorry, I'm missing why. Hooks can be called separately, but the expected flow to use them is...

> The container happens to be a convenient place to run the hooks since it seems to have the required dependencies I'm not opposing the case, but just wanted to...

> Aha, it looks like [recent node installs now need libatomic](https://github.com/nodejs/node/issues/60790). I'm missing where do we need to install node to run pre-commit hooks.

I removed node from my system and tried to run hooks: I'll try to replicate the issue if you have a way to reproduce it.

That's possible, but I can't follow you, sorry. If it's required for node, but node is not required for hooks, why would we need libatomic1? I checked my system to...

One more "change requeest" here would be that we are in the process of moving the test setup to Docker so if we are adding anything, I'd expect them not...

> Marked the pr as draft as need the website wg to agree on the proposal 👍 Adding to the agenda for the next meeting.

+1 for the general idea. > This could be just a new file or folder in this repository? I think so. > Public docs to share information with other contributors...