Thomas

Results 176 comments of Thomas

Ah, makes sense. Thank you! I also found that revisions for commits do work. I'll see about cutting a PR for working with tags too.

> @uhthomas fwiw I tried to use Bazel 6-pre in order to test out the optional toolchain support. Is there something specific I need to do to opt into that...

A nice solution may be to use `only_files` instead where: ```starlark def nogo_config(name, config = {}, only_files = [], **kwargs): for v in only_files: config.setdefault(v, {}).update({ "only_files": { "example.com/module": "first-party...

@tomqwpl This isn't quite the same issue you're describing, though hopefully this will be helpful: We generate our nogo config with starlark, which means we can much more easily exclude...

@tomqwpl That's a shame, I think nogo has a lot of potential. I do however understand the frustration, and you are not alone. Google's gVisor wrote their "nogo" to address...

Hi @jsharpe. What is the status of this issue? Is there any guidance on how best to achieve this? Thanks :)

Ah, I see, thank you. Does the example you worked on also support autoreconf? I'd be really interested to help make this better.

Not necessarily a "small" example, but as far as I understand capnproto is using autoreconf. Trying to get this working with rules_foreign_cc at the moment and struggling a bit. https://github.com/capnproto/capnproto/tree/281aacc18003ae103b8a04ea83d7b6f814c97b8b/c%2B%2B

Sounds reasonable to me. Do you have a recommended path forward for this? As mentioned before, I'd be happy to help where possible. Though my knowledge of the C/C++ toolchains...

Cool! For what it's worth I tried building with the autotools example and didn't have too much luck. ``` + autoreconf configure.ac:70: warning: The macro `AC_LANG_C' is obsolete. configure.ac:70: You...