Top 30 Albums Page

[tanzeelak]

Created grid layout for albums. Albums resize at different screen widths, but needs improvement. Tabs do not look like the mockup but are functional. Info in the panel version is as follows.

{ album: 'Enchant', artist: 'Emilie Autumn', imgurl: 'https://tytmb.files.wordpress.com/2011/10/enchant1.jpg', albumreview: '[tumblr-link-review]' }

[binerys]

Hi Tanzeela, can you change the PR to be more descriptive (ie Top 30 Albums Page). Additionally, please add a screenshot! Thanks :)

You can use my PR for reference

[nathanmsmith]

@binerys recommending her own PR as a reference LOL (In all seriousness though, it's a great PR.)

Also, I noticed there were changes made to public/build/frontpage.min.js. I was under the impression that @ChrisLaganiere added public/bulid to our .gitignore, is this branch totally up-to-date with master?

[binerys]

Updated the branch so that it's rebased with master per @nathunsmitty's suggestion. While rebasing with master, I fixed a routing conflict so the feature is accessible via localhost:3000/topalbums.

Some additional comments:

• Fix image stretching in mobile view

• "Click for Review" link is colored black and hard to see in overlay

[binerys]

5f6306b fixes the issue where album reviews should only appear if albumReview is specified.

Some other things I noticed: If a review is not specified, the overlay looks like this:

But if a review is specified, the overlay looks like this:

Can you fix it such that the white text is consistent for artist and album name are consistent throughout?

[ChrisLaganiere]

Awesome work! Looks great with the changes