uclaradio.com icon indicating copy to clipboard operation
uclaradio.com copied to clipboard

Stream Marquee

Open jdliaw opened this issue 7 years ago • 2 comments

Types of changes

  • [ ] Bugfix (change which fixes an issue)
  • [x] New feature (change which adds functionality)
  • [ ] Refactor (change which changes the codebase without affecting its external behavior)
  • [ ] Non-breaking change (fix or feature that would causes existing functionality to work as expected)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Purpose

Add a marquee to the stream bar to post announcements, on-air giveaways, or display the on-air/request line numbers, etc.

Approach

Created a new StreamMarquee component that takes in a message as props and uses webkit-animation to move and look nice.

Screenshot(s)

img

Checklist

  • [ ] My branch follows the branch naming scheme of UCLA Radio, and can merge into master without error.
  • [ ] My code follows the code style of this project, and I have linted it to confirm this.
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • [ ] My change requires a change to the documentation and I have updated the documentation accordingly.
  • [ ] All new and existing tests passed.

jdliaw avatar Feb 01 '18 22:02 jdliaw

should we just not show it on mobile view? since the bar is kinda too small

jdliaw avatar Feb 20 '18 20:02 jdliaw

@jdliaw Yeah I agree. It's really small and would be impossible to read the phone number.

binerys avatar Feb 20 '18 23:02 binerys