hammer icon indicating copy to clipboard operation
hammer copied to clipboard

Pass p_syn_in to hierarchical make rules.

Open jerryz123 opened this issue 4 years ago • 2 comments

Previously, hierarchical steps did not see a dependence on inputs.yml, sram-generator-output.json, and your INPUT_CONFS in the hierarchical flow.

A bug could occur if the hierarchical module contained its own SRAM macro that no leaf module included. Without appending to p_syn_in, sram-generator-output.json would not be included, and the tools would not be able to resolve the path to this macro.

jerryz123 avatar Apr 14 '21 00:04 jerryz123

It is usually very annoying to have the later steps depend on INPUT_CONFS. From my reading of the change you are just adding them as inputs without adding them as dependencies, which avoids this issue. However I feel like you might want to only include the sram-generator-output.json instead of all inputs.

colinschmidt avatar Apr 14 '21 16:04 colinschmidt

I thought the workaround for that is to just use redo steps.

Not sure how I can parse out just the sram-generator-output.json without adding a weird special case here.

jerryz123 avatar Apr 19 '21 19:04 jerryz123