gemmini icon indicating copy to clipboard operation
gemmini copied to clipboard

Added support for non-zero padding in instructions mvin and loop_conv_ws

Open fzi-peccia opened this issue 2 years ago • 3 comments

Proposal to solve #229

fzi-peccia avatar Jan 12 '23 11:01 fzi-peccia

This is great, thank you! Do you think you could update gemmini_config_ld and gemmini_loop_ws in gemmini.h to reflect the new padding_value parameter?

Also, could you update ConfigMvinRs1 to also reflect the new parameter you added?

No worries if you don't have the time to make these changes; I can add them myself. But it might be a bit before I have the time.

hngenc avatar Jan 21 '23 07:01 hngenc

Hi @hngenc, sorry for the delay.

I added the padding_value in gemmini-rocc-tests to all places where it could be needed. See https://github.com/fzi-peccia/gemmini-rocc-tests/tree/non_zero_padding

fzi-peccia avatar Apr 27 '23 07:04 fzi-peccia

Hi @hngenc, I created the pull request for my changes in gemmini-rocc-tests https://github.com/ucb-bar/gemmini-rocc-tests/pull/37

fzi-peccia avatar May 31 '23 07:05 fzi-peccia