berkeley-softfloat-3 icon indicating copy to clipboard operation
berkeley-softfloat-3 copied to clipboard

Sync with softfloat from spike

Open troibe opened this issue 1 year ago • 2 comments

Spike seems to use a slighty modified version of softfloat 3d with some additions that are not present in this 3e version. Would it be possible to sync them up again?

In particular I'm personally missing in this 3e release:

  • f32_rsqrte7
  • f64_rsqrte7
  • f32_recip7
  • f64_recip7

I'm happy to create a pull request for this but I first wanted to make sure I didn't overlook something... E.g. there is a valid reason the versions are incompatible currently. Or the functions I'm looking for exist but under a different name.

troibe avatar Jan 14 '24 16:01 troibe

Spike seems to use a slighty modified version of softfloat 3d with some additions that are not present in this 3e version. Would it be possible to sync them up again?

I believe spike forked the 3d release, then later on, added those instructions. Adding those instructions to this repo should be fine.

I don't know why spike forks the source, instead of including this repo as-a-submodule. Including this repo as a submodule would prevent divergences like this in the future. Perhaps you can raise an issue in Spike on this.

jerryz123 avatar Jan 14 '24 18:01 jerryz123

@jerryz123 Regardless of how they want to integrate these changes in Spike, I'll try to put together an update PR in this repo over the weekend.

troibe avatar Feb 22 '24 17:02 troibe