barstools icon indicating copy to clipboard operation
barstools copied to clipboard

Clean up the assembly process

Open chick opened this issue 4 years ago • 4 comments
trafficstars

Assembly of a jar using main from MacroCompiler is fixed.

I don't see anywhere where this is used. So I'm not sure what may be affected by the placement of the generated jar in ./utils/bin.

  • Bump version so it's in step with Chisel3 3.5
  • Avoid error on duplicate classes
  • put jar in utils/bin, the same way that firrtl does assembly
  • add calling script ./utils/bin/macro_compiler.sh

chick avatar Sep 27 '21 19:09 chick

Is there supposed to be a script added (according to the PR description)?

abejgonzalez avatar Sep 28 '21 05:09 abejgonzalez

I don't think CY currently uses this JAR, so is the point to make it this easier to use when we move to a published version of this repo?

abejgonzalez avatar Sep 28 '21 05:09 abejgonzalez

I haven't bumped and tested in chipyard. I'll give that a try, but barstools master is now on chisel 3.5-snapshot, I think that might be a problem

chick avatar Sep 28 '21 17:09 chick

Not sure about the script added. I was just flushing the assembly out a bit with the firrtl convention for providing a script to run the assembled jar. I don't think CY uses this at all. The assembly process looks like @edwardcwang added it. I think assembly jars are nice because they spin up way faster than sbt, so ultimately it would be good to get chipyard to use them where feasible.

chick avatar Sep 28 '21 17:09 chick