YutaSaito

Results 17 comments of YutaSaito

@jmcdo29 @kamilmysliwiec Thank you. Certainly the above is not supported. Please wait a moment as there is one idea.

I changed to keep the globalprefix set by httpadapter. With this fix, NotFoundException is thrown at the right time. ## example ``` const server = express(); const adapter = new...

>What would happen if someone set notFoundHandler: true on both? Would it come around to the same issue? I also think the same issue occur. Could you review the commit...

If catsApp is set `notFoundHanlder: false` and dogsApp is set 'notFoundHanlder: true`, It will be as follows. | Handler | Route | ----|----- | Router | /cats | | NotFound...

I'm sorry. I think my way of communicating was not good. I want to solve this problem. What should I do? If you proceed with adding properties, there is a...

I understanded the cause. `adminApp` and `apiApp` each run registerRouterHooks methods run when init method run. This makes the Router look like this. 1. Router: /admin/admin 2. Midrreware: / (NotFoundHandler)...

@kamilmysliwiec Hello! Thank you as always. Could you tell me why did you revert the following PR in commits (`fc7d94be65aacba412cd2fd7541b5628bffc2cd9`) and (`ea07fb7e169566b31025756a800bff3e9490626a`)? https://github.com/nestjs/nest/pull/3656 If the reason of the revert is...

@kamilmysliwiec I see. I think We can address this issue while maintaining compatibility, so I will fix it. Please let me know if you do not want to fix it....

@tomakehurst Thank you. Do your tests fail sometimes? If the test always succeeds, it may be called from `@WireMockTest` attached to the parent class. If `@WireMockTest` is given to both...

I've tested it several times and it all passes on my local. Can I try running GitHub Actions a few times? Is `JunitJupiterExtensionDeclarativeWithConfiguredNestedTest` an example test class that fails?