Urs Bulling
Urs Bulling
The CT-AUX accumulator tries to write two functions with the name "no-name". See https://github.com/CompFUSE/DCA/blob/ed9406d2615dfc7e99e9d488d1c58b0a876b3d52/include/dca/phys/dca_step/cluster_solver/ctaux/ctaux_accumulator.hpp#L316 and https://github.com/CompFUSE/DCA/blob/ed9406d2615dfc7e99e9d488d1c58b0a876b3d52/include/dca/phys/dca_step/cluster_solver/ctaux/accumulator/tp/tp_equal_time_accumulator.hpp#L248 This causes the HDF5 writer to throw an exception and the whole main_dca to...
I don't know whether CtauxClusterSolver::computeErrorBars is usually executed. But if it is, we make a redundant copy of G4: https://github.com/CompFUSE/DCA/blob/master/include/dca/phys/dca_step/cluster_solver/ctaux/ctaux_cluster_solver.hpp#L402 @gbalduzz Any thoughts on that?
The jackknife error on G4 is computed even when four-point-type = NONE: https://github.com/CompFUSE/DCA/blob/master/include/dca/phys/dca_step/cluster_solver/ctaux/ctaux_cluster_solver.hpp#L288 Besides the redundant computation, this also causes the memory for G4_err_ in DcaData to be allocated.
`SpaceTransform2D::execute(func::function& f_input)` and `SpaceTransform2D::execute(func::function& f_input, func::function& f_output)` seem to use different conventions for where to put the normalization constant. See e.g. https://github.com/CompFUSE/DCA/blob/2583dba4fca20ce9181d345c3b62fbe3ce6cd82c/include/dca/math/function_transform/special_transforms/space_transform_2D.hpp#L95 @gbalduzz Can you clarify and document this in...