CoordConv issues

Cannot reproduce results of "coordconv_rendering" task

I get zero accuracies by running the instructed command: ``` # coordconv version python train.py --arch coordconv_rendering -mb 16 -E 100 -L 0.005 --opt adam --l2 0.001 -mul 1 --use_mse_loss...

hubert0527

Wrong denominators when normalize xx_channel and yy_channel?

1

Hi, in your code you normalize xx_channel and yy_channel as following: https://github.com/uber-research/CoordConv/blob/27fab8b86efac87c262c7c596a0c384b83c9d806/CoordConv.py#L70 https://github.com/uber-research/CoordConv/blob/27fab8b86efac87c262c7c596a0c384b83c9d806/CoordConv.py#L71 I think it should be: `xx_channel = tf.cast(xx_channel, 'float32') / (self.y_dim - 1)` `yy_channel = tf.cast(yy_channel, 'float32')...

jiayily

Fixed bug in AddCoords, where the normalization of x and y coordinate…

2

…s is reversed. As a result, the coordinates doesn't belong to interval [-1,1] when x_dym != y_dim.

jeanibarz

Python3 Compatibily for data generation

1

In Python 3, dict.keys doesn't return a list, but something like a set that doesn't support indexing. To make indexing possible, it is necessary to convert that to a list.

hmrishavbandy