CoordConv icon indicating copy to clipboard operation
CoordConv copied to clipboard

Wrong denominators when normalize xx_channel and yy_channel?

Open jiayily opened this issue 4 years ago • 1 comments

Hi, in your code you normalize xx_channel and yy_channel as following: https://github.com/uber-research/CoordConv/blob/27fab8b86efac87c262c7c596a0c384b83c9d806/CoordConv.py#L70 https://github.com/uber-research/CoordConv/blob/27fab8b86efac87c262c7c596a0c384b83c9d806/CoordConv.py#L71 I think it should be: xx_channel = tf.cast(xx_channel, 'float32') / (self.y_dim - 1) yy_channel = tf.cast(yy_channel, 'float32') / (self.x_dim - 1) That is the denominators are wrong?

jiayily avatar Feb 07 '21 08:02 jiayily

Yes it is, there are already 2 pull requests for that issue (one created since 2020). I think that the repository is not maintained anymore.

jeanibarz avatar Feb 23 '21 21:02 jeanibarz