zhangyaning

https://github.com/nervosnetwork/ckb/blob/develop/resource/Cargo.toml#L21 If there are some same crates in `dependencies` and `build-dependencies` respectively, they should not be unused dependencies.

At geth ``` > token.setList.sendTransaction(1, [1,2,3], {from: web3.eth.accounts[0]}) I0823 19:06:55.928172 eth/api.go:1193] Tx(0x0f593383ea3597d9d0d4726c0ba4eb9fdc61b541b4a39a686bf9baf88d01680e) to: 0x4f4f00a3a4567cd765e26614690012fcd9e97053 "0x0f593383ea3597d9d0d4726c0ba4eb9fdc61b541b4a39a686bf9baf88d01680e" > I0823 19:07:01.976182 miner/miner.go:119] Starting mining operation (CPU=4 TOT=5) I0823 19:07:01.979166 miner/worker.go:573] commit new work...

teth g NodeManager

mining contract failed

2

When I ran the test, I found that geth could not mine contract. ``` $ geth --dev --genesis genesis_block.json --datadir ./data console 2>> out.log.geth instance: Geth/v1.3.2/darwin/go1.5.1 datadir: data coinbase: 0xd2bfd41dfd7932d5daa46d26770b8685f3f6a556...

Split crates

11

I consider we could move `kvdb` in a separate crate. What about removing the `avl` or moving to another repo firstly, because it is written base on the trie, it's...

https://github.com/nervosnetwork/ckb/blob/develop/rpc/src/module/chain.rs#L11 https://github.com/paritytech/parity-ethereum/blob/master/rpc/src/v1/traits/eth.rs#L27

BFT应该需要对proposal的时间进行验证

3

原因： 合约的某些行为需要依赖区块的时间，如果不对时间进行验证，单一节点作为proposal就可以轻易作恶。 提议： validator对proposal进行验证投票的时候，需要对proposal的时间进行验证。这里的时间验证不同于公链。 需要注意： 这里可能会对共识的规则产生一些影响，比如对未来高度的投票，比如多轮共识未达成等等。