Zach Bonfil

Results 13 comments of Zach Bonfil

I raised the question in a webpack https://github.com/webpack/webpack/issues/15971

> You can skip this issue by also sharing any submodule of swr changing this: > > ``` > new webpack.container.ModuleFederationPlugin({ > shared: ['swr'], > }), > ``` > >...

I guess there should be a distinction between failing the build and exiting the whole process with code 1. For example, if the user is using watch mode you don't...

> Ok, in my experiments, throwing in `buildStart` does NOT abort watch mode and thus should behave exactly like `transform` or `load` etc. It is only throwing in `watchChange` that...

> > I tried to fork this repo and use the branch > > > > I was wondering why you did not simply run `npm install rollup/rollup#gh-4424_throw_watch_change` as the...

> I pushed a potential solution to #4427 which will make the `watchChange` and `closeWatcher` hooks async. Amazing, I tried this branch and it works as expected!

I will share my insights after a little more investigating: * When I add `swr` to the shared dependency, it treats it as `commonjs` only when it resolves from the...

Another small breakthrough for me. When I added to the [webpack `.mjs` default](https://github.com/tzachbon/webpack/blob/9fcaa243573005d6fdece9a3f8d89a0e8b399613/lib/config/defaults.js#L547) the following config it works: ``` { test: /\.mjs$/i, descriptionData: { type: "module" }, ...esm }, ```...