Ty Smith

Results 51 comments of Ty Smith

Suggest a first pass with a custom built dependency to understand the scope of the migration

Yeah, using byte for storage makes sense. Tentatively, I'd expect a wrapper/util on top to facilitate easy to use APIs for consumers.

> What does your `init.gradle` say? (Typically located at `~/.gradle/init.gradle`) > > One may need to add a `allowInsecureProtocol = true` to that file That file shouldn't exist anymore. Our...

Here's our current one at Uber. Intellij and Ktlint will read from this for indent_size, continuation_indent_size, and max length (I believe) ``` [*.{kt,kts}] indent_size=2 continuation_indent_size=4 insert_final_newline=true max_line_length=120 disabled_rules=package-name ```

> Copy from https://github.com/detekt/detekt/issues/7200 since the same argument applies here. @schalkms just confirming that if type resolution was supported for this rule, we would expect both usecases (the flow one...

Thanks for the fix! However, it is mostly unrelated to the issue you mentioned #499. The intention of that task was just to add leak canary integration to the sample...

> Hey @tyvsmith! I thought the Compose sample-app is just an example of how to reproduce the memory leak. > If in that issue we were supposed to just add...

This would also have the benefit of removing the dependency on autodispose for coroutines usage.

We are pushing heavily towards Compose and coroutines internally, so that demo is the most up to date. The tutorials have not been updated in a while.

We should re-enable japicmp for the short term, then discuss the trade-offs between the Jetbrains solution for a longer term approach. @jbarr21 You originally chose japicmp, was that only because...