RIBs icon indicating copy to clipboard operation
RIBs copied to clipboard

proposal to detach children before self

Open davissuber opened this issue 2 years ago • 4 comments

This pull request stems from https://github.com/uber/RIBs/issues/589 and attempt to swap the detachment order between self and any attached children to avoid a small window in which the child is active and parent is not.

Note that this only updates the Android part - the corresponding iOS behavior remains "detach self before children" even after this pull request.

davissuber avatar Aug 23 '23 18:08 davissuber

Has this been verified in the Uber monorepo? Tests passed and apps worked?

tyvsmith avatar Aug 23 '23 18:08 tyvsmith

Has this been verified in the Uber monorepo? Tests passed and apps worked?

No, not yet - was creating this pull request to collect information on whether to do this at all (and if yes, gather information on what would be considered a sufficient test)

davissuber avatar Aug 23 '23 18:08 davissuber

Suggest a first pass with a custom built dependency to understand the scope of the migration

tyvsmith avatar Aug 23 '23 18:08 tyvsmith

Update: After smoke testing with Uber's big apps, decided to limit the change to only move the "detach self" ahead of "detach children" and leave the "will detach" position untouched

davissuber avatar Aug 24 '23 22:08 davissuber