Martin Raifer
Martin Raifer
This looks like great improvements, thank you very much! But can you please complete a few more things before I can merge it (and make it into a v0.6 release):...
For a small library such as this one, I usually try to keep external dependencies to an absolute minimum. I'll look over the documentation, of course.
from https://github.com/tyrasd/jxon/pull/32#issuecomment-239794380: > If you want, I can try to fix Sure, go ahead! :+1: I'm a bit surprised that the phantomjs in test-webkit doesn't preserve the declaration, but I...
which version of jxon are you using?
OK… but, under what circumstances does an AMD `define` exist in a node environment? :thinking:
> supports only version, encoding and standalone that's ok, because these are the only three allowed pseudo-attributes of the xml declaration (see https://www.w3.org/TR/2004/REC-xml-20040204/#sec-prolog-dtd) > using the default attrPrefix Yeah, that's...
Hi Greg. Thanks for the PR, but can you please elaborate a bit of what this changes are about and what this would be used for?
> doesn't this PR miss the part where the key is added to the preset? > [`"type": "sidewalk"`] isn’t a valid type Correct. I've just used the PR from @arch0345...
> Black Buoy this option doesn't seem to be documented on the [wiki for `seamark:buoy_lateral:colour`](https://wiki.openstreetmap.org/wiki/Key:seamark:buoy_lateral:colour) and also has almost [no uses](https://taginfo.openstreetmap.org/tags/seamark%3Abuoy_lateral%3Acolour=black) on osm as far as I can see. //edit:...
In general, the [distribution of values](https://taginfo.openstreetmap.org/keys/seamark%3Abuoy_lateral%3Acolour#values) is pretty red/green heavy. At first glance, having the two presets for red and green and the generic preset for all other colors looks...