Kai Ren

Results 254 comments of Kai Ren

@faramozzayw btw, go ahead 😅 I can even provide a good review for it!

@quapka thanks for bringing this up! Sorry for late reply, this is because all the maintainers have low bandwidth to dedicate to this project. We'll add the security policy closer...

@quapka I guess for the moment, you may reach me or @LegNeato privately by the email address, specified in commits.

@Denommus yup, this is somewhat non-symmetrical. The `juniper` was designed considering possible dynamic GraphQL types, but was never really used/polished for them. With landing #1072 we'll have better core traits...

@Denommus what do you mean by "check the type of an argument"? An argument is given as an `InputValue` it has no type. `GraphQLValue` implementor decides which type to "deserialize"...

@Denommus whether the type matches GraphQL schema is checked in a validation layer, before doing resolve.

@Denommus yeah, it actually reuses `FromInputValue` implementation in the way: `|v| T::from_input_value(&v).is_ok()` I wonder whether we can specify `Context` and `TypeInfo` there. Seems that there is nothing wrong with it,...

@jerel as far as I recall, this is not supported at the moment. The reason is that is not clear how such situations should be resolved. A subscription in a...

@jxs @LegNeato looking at the code in the [current master](https://github.com/graphql-rust/juniper/tree/aedb2d1eb453f605380ff527f88d7467253ba341), the described above is totally non-issue. `RwLock`'s locking is used in a [single place only in sync function](https://github.com/graphql-rust/juniper/blob/aedb2d1eb453f605380ff527f88d7467253ba341/juniper/src/executor/mod.rs#L608) and there...

Wondering why it's not in the spec yet, the explanation is here: https://github.com/graphql/graphql-spec/pull/525#issuecomment-830397550