typicalninja

Results 9 comments of typicalninja

Nice. If you want feel free to PR it in. will need few changes as we seperate the selectors into a separate package

It might be best to just add a TSDoc comment explaining that the request config needs to be modified. The original idea of selectors was to keep them focused purely...

We will have to do 1 anyway, I think 3 would be the best way, since it directly matches the Google's query param

Maybe try changing the [`responseEncoding`](https://axios-http.com/docs/req_config) option of the axios config. you can pass it to google-sr with the `requestConfig: {}` option. I am currently away and cannot test if this...

i am pretty sure axios relies on the `content-type` header from google to figure out how to decode the request. since they are using `utf-8` that's what it will use....

@devsakae you need to provide `responseEncoding` key in `requestConfig` Your code needs be like this: ```ts const queryResult = await search({ query: "docker", resultTypes: [OrganicResult, DictionaryResult], requestConfig: { responseEncoding: "ISO-8859-1",...

I did notice this while testing. seems like i have to make the selectors a bit more specific. for now try using the [`strictSelector`](https://github.com/typicalninja/google-sr/blob/master/packages/google-sr/API.md#searchoptionsr--resultselector) option. it should remove any result...

Adding to above, while i know about this issue. i could not reproduce it with the query you gave. might be geolocation specific

this got fixed somehow, we are looking at a rewrite anyway #51. closing this as bug did not exist before rewrite was decided