Mark Tyneway
Mark Tyneway
We also need to move some fields out of the roles section because it will result in the same issue. The ~~unsafe block signer and~~ batch submitter are part of...
> My understanding is that we still need the `[optimism]` section in the chain config .toml files, but we want to move it from its own section and instead embed...
We should be able to make this change completely contained within this library, no need to cascade the changes into other codebases. So please do not introduce a breaking API...
> > We should be able to make this change completely contained within this library, no need to cascade the changes into other codebases. So please do not introduce a...
We could add the configs to the [superchain-registry](https://github.com/ethereum-optimism/superchain-registry) to make it easy for people to run their own nodes on the devnet but I believe that will just add extra...
@coderabbitai summary
@coderabbitai Double check that all of the tests from `OptimismPortal.t.sol` involving custom gas token have been ported to `OptimismPortal2.t.sol`
@mds1 - I went through and made sure all of the tests were ported from the original implementation
> I assume in a follow up PRs we will delete the original portal then rename portal2 to portal? Yup, exactly! > Unfortunately I did not get a chance to...
@mds1 There has been no progress on this PR while you have been on vacation, but I did go through myself to double check that all the tests were ported...