Mark Tyneway

Results 574 comments of Mark Tyneway

There is currently some discrepancies between using `IsInterop` vs `IsIsthmus` - we need to standardize the usage, just to be mindful of

Coupling this work with a design of the `OptimismPortal` that doesn't enshrine the [DisputeGameFactory](https://github.com/ethereum-optimism/optimism/blob/f16e725b14c90c8c2a659ee836f0f9ef7e807c7f/packages/contracts-bedrock/src/L1/OptimismPortal2.sol#L90) or the [L2OutputOracle](https://github.com/ethereum-optimism/optimism/blob/f16e725b14c90c8c2a659ee836f0f9ef7e807c7f/packages/contracts-bedrock/src/L1/OptimismPortal2.sol#L82) would be nice. This would look like decoupling `proveWithdrawalTransaction` and `finalizeWithdrawalTransaction` specific implementations...

I would like to build a little more confidence in this being the solution given the work going on in https://github.com/celo-org/optimism/pull/213 before merging

This is a good catch. I lean towards saying the spec is correct and updating the implementation to handle either `/put` or `/put/`

It may be possible to use a peer authentication scheme like [bip 150](https://github.com/bitcoin/bips/blob/master/bip-0150.mediawiki) before upgrading to the brontide connection. ``` This BIP describes a way for peers to authenticate to...

@sebastianst can we merge this PR?

Maybe its time to take a look at https://github.com/handshake-org/hsd/pull/69, which migrates the `bcoin` style indexers to `hsd`. The `NameIndexer` could be built on top of this.

/ci authorize https://github.com/ethereum-optimism/optimism/pull/16408/commits/c54b34e1f5fe40b9e3d9376690960179dda58156

/ci authorize https://github.com/ethereum-optimism/optimism/pull/16408/commits/637bf0da3ebcbac5c6c4a738fa32b467455fa10b

/ci authorize https://github.com/ethereum-optimism/optimism/pull/16408/commits/80a2d9b71c7a627476f51168e4b98efad7ae5a6f