Mark Tyneway
Mark Tyneway
``` Failing tests: Encountered 1 failing test in test/L2/SuperchainWETH.t.sol:SuperchainWETH_Test [FAIL. Reason: log != expected log; counterexample: calldata=0x8f13455d00000000000000000000000000000000000000000000000000000000000058e40000000000000000000000000000000000000000000000000000000000000385 args=[22756 [2.275e4], 901]] testFuzz_sendERC20_sufficientFromCustomGasTokenChain_succeeds(uint256,uint256) (runs: 439, μ: 97974, ~: 98166) ```
Appreciate the PR @jinmel! It is going to be difficult to maintain this diff as its a big copy/paste of a lot of code, we can reduce the diff with...
Yes this is intended! It was designed this way, to enable many chains to use the same implementations to make upgrades cheaper
Need to try this out locally before approving but super appreciate the help here! Is it working locally for you?
@Inphi do you mean patch semver?
Thoughts on squashing this into a single commit before merge? Or we just do squash merges over here?
I am more open to the idea of sending the conditional requests via p2p even tho there is no way to make sure they are not malleated
Curious what you think @protolambda about the P2P part of this that was previously implemented
> Curious what you think @protolambda about the P2P part of this that was previously implemented Looks like we don't need it due to changes to `proxyd` where it can...
Generally looks good to me, just a few open nits/questions